Objective To explore the relationship between smoking, alcohol drinking and gallstone disease in general male population in Guangdong. Methods Each subject received a questionnaire and took an upper abdominal ultrasound examination in a cross-sectional study. Results The prevalence of gallstone disease became higher with the increase of amount of cigarette smoking per day (trend test ?2=5.542, P=0.019) and with the total amount of cigarette smoking in their life (trend test ?2=7.302, P=0.007), these significance remained after controlling well-known risk factors for gallstone disease such as age and body mass index (BMI) (OR=1.269,95%CI: 1.018~1.580 for cigarette smoking per day and OR=1.295, 95%CI: 1.020~1.646 for total ). Little to moderate alcohol drinking (