Objective: To analyze the trends of smoking and drinking behaviors among adolescents in Shanghai from 2004 to 2019, and to provide theoretical evidence for effective tobacco and alcohol interventions among adolescents. Methods: Data regarding smoking and drinking behaviors from adolescent health risk behavior surveillance program in Shanghai from 2004 to 2019 were collected, and the prevalence of ever smoking, current smoking, ever drinking and current drinking were comparatively analyzed. Results: The prevalence of ever smoking, current smoking, ever drinking and current drinking among boys were significantly higher than those among girls in 2004 to 2019( χ 2=58.20-347.44, P <0.01). Except the prevalence of ever drinking in 2012, the prevalence of ever smoking, current smoking, ever drinking and current drinking in vocational school students were the highest in each survey( χ 2=111.19-1 196.61, P <0.01). From 2004 to 2019, the standardized rates of smoking and drinking of boys and girls showed a downward trend ( APC =-6.20--1.80, P <0.05). The standardized ever smoking rate and the standardized ever drinking rate of both boys and girls declined significantly from 2004 to 2019（ APC=-5.00, -1.80, P ＜0.05）. The overall standardized rate of ever smoking decreased from 21.02% in 2004 to 12.23% in 2019, and that of ever drinking decreased from 60.52% in 2004 to 47.17 % in 2019）. However, the overall standardized rates of current smoking and current drinking did not reach statistically significance（ P >0.05）. Conclusion From 2014 to 2019,the prevalence of ever smoking and ever drinking among adolescents in Shanghai over the observed period showed a declining trend by years, but there was no significant change in current smoking and current drinking among adolescents. Specific interventions targeting on smoking and drinking behaviors among adolescents need to be strengthened.